Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DesignSpace 5 #292

Merged
merged 8 commits into from
Nov 22, 2022
Merged

Add support for DesignSpace 5 #292

merged 8 commits into from
Nov 22, 2022

Commits on Nov 22, 2022

  1. Give subclasses a change to name their collection items

    @justvanrossum
    justvanrossum committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    cff3d18 View commit details
    Browse the repository at this point in the history

  2. There can be multiple VFs in a DS5 file; use the fontNumber mechanism

    @justvanrossum
    justvanrossum committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    651acbc View commit details
    Browse the repository at this point in the history

  3. Add optional nameInCollection argument, for nicer display names of co… 

    …llection items
    @justvanrossum
    justvanrossum committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    5b7631b View commit details
    Browse the repository at this point in the history

  4. take fontNumber into account, as an index into the DS5 variable fonts… 

    … list
    @justvanrossum
    justvanrossum committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    4bcba2d View commit details
    Browse the repository at this point in the history

  5. Pass fontNumber into DS compiler

    @justvanrossum
    justvanrossum committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    6b66005 View commit details
    Browse the repository at this point in the history

  6. Pass the nameInCollection to setFontItem, for nicer display name of c… 

    …ollection items
    @justvanrossum
    justvanrossum committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    216b410 View commit details
    Browse the repository at this point in the history

  7. Adjust expected results

    @justvanrossum
    justvanrossum committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    0aadb30 View commit details
    Browse the repository at this point in the history

  8. Add outline test for DS5

    @justvanrossum
    justvanrossum committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    5321481 View commit details
    Browse the repository at this point in the history