Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: add support for OTEL #1109

Merged
merged 1 commit into from
Dec 2, 2024
Merged

tracing: add support for OTEL #1109

merged 1 commit into from
Dec 2, 2024

Conversation

netsi
Copy link
Collaborator

@netsi netsi commented May 24, 2024 •
edited
Loading

Feature

  • Add OTEL support to the tracking pkg.
  • Instrument http and grpcserver packages

Breaking Changes

xray tracing config structure has changed before:

tracing:
  provider: xray
  addr_type: local
  addr_value: ""

after:

tracing:
  provider: xray
  xray:
    addr_type: local
    addr_value: ""

Usage examples

tracing:
  provider: otel
  otel:
    exporter: otel_http
    http:
      endpoint: localhost:4318
      url_path: /v1/traces
      compression: true
      insecure: true
      timeout: 10s
      retry:
        enabled: false

@netsi netsi force-pushed the tracing-otel branch 2 times, most recently from 5befbb0 to 22e2926 Compare July 1, 2024 13:29
@netsi netsi requested a review from j4k4 July 1, 2024 14:23
ajscholl
ajscholl reviewed Jul 29, 2024
View reviewed changes
pkg/kafka/consumer/consumer_offset_manager_test.go Outdated Show resolved Hide resolved
pkg/grpcserver/server.go Outdated Show resolved Hide resolved
pkg/grpcserver/server.go Show resolved Hide resolved
pkg/tracing/tracer.go Outdated Show resolved Hide resolved
pkg/tracing/tracer.go Outdated Show resolved Hide resolved
pkg/tracing/tracer_otel.go Outdated Show resolved Hide resolved
@netsi netsi force-pushed the tracing-otel branch 3 times, most recently from 247c5bf to 0231346 Compare September 16, 2024 12:01
@netsi netsi requested a review from ajscholl September 16, 2024 12:06
ajscholl
ajscholl reviewed Sep 17, 2024
View reviewed changes
pkg/tracing/instrumentor_aws.go Outdated Show resolved Hide resolved
pkg/tracing/instrumentor_otel.go Outdated Show resolved Hide resolved
pkg/tracing/tracer.go Outdated Show resolved Hide resolved
pkg/kafka/consumer/consumer_offset_manager_test.go Outdated Show resolved Hide resolved
@netsi netsi requested a review from ajscholl September 18, 2024 11:47
@netsi netsi requested review from j4k4 and removed request for applike-ss and j4k4 September 23, 2024 12:03
@netsi
Copy link
Collaborator Author

netsi commented Sep 23, 2024

@j4k4 can we merge this one if you agree?
I don't have the permission to do it.

@netsi netsi force-pushed the tracing-otel branch 5 times, most recently from 0c3ed37 to 3e428de Compare November 26, 2024 17:54
ajscholl
ajscholl reviewed Nov 27, 2024
View reviewed changes
pkg/tracing/context_trace.go Outdated Show resolved Hide resolved
pkg/tracing/tracer_aws.go Show resolved Hide resolved
pkg/tracing/tracer_noop.go Outdated Show resolved Hide resolved
pkg/tracing/tracer_local.go Outdated Show resolved Hide resolved
ajscholl
ajscholl reviewed Nov 29, 2024
View reviewed changes
pkg/tracing/otel_exporters.go Outdated Show resolved Hide resolved
pkg/tracing/otel_exporters.go Show resolved Hide resolved
pkg/tracing/otel_exporters.go Outdated Show resolved Hide resolved
pkg/tracing/otel_trace_provider.go Outdated Show resolved Hide resolved
pkg/tracing/otel_trace_provider.go Outdated Show resolved Hide resolved
pkg/tracing/tracer_otel.go Show resolved Hide resolved
@j4k4 j4k4 merged commit c54107d into justtrackio:main Dec 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajscholl ajscholl ajscholl approved these changes

@j4k4 j4k4 Awaiting requested review from j4k4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netsi @ajscholl @j4k4