fix: Don't replace .d.ts paths #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeAbby
commented
Dec 22, 2024
Comment on lines
+86
to
+88
| const dotIndex = base.indexOf('.'); | ||
| const name = base.slice(0, dotIndex); | ||
| const extension = base.slice(dotIndex); |
There was a problem hiding this comment.
You might wonder why I did this instead of just using the extension already given to me by parse. This is because they consider xyz.d.ts to have a name of xyz.d and an extension of .ts
src/utils/trie.ts
Outdated
| const extension = base.slice(dotIndex); | ||
|
|
||
| const normalizedExtension = extension.replace( | ||
| /^\.([mc])?ts(x)?$/, |
There was a problem hiding this comment.
I added a ^ which means the whole extension must be matched. This may need to have smarter logic.
Files to definitely exclude:
foo.d.css.ts- The correct way of defining a declaration file forfoo.cssfile. Cannot point to ajsfile.foo.css.d.ts- A legacy way of defining afoo.cssfile. Cannot point to ajsfile.foo.d.ts- Declaration files for a JS file. This JS file could technically exist in repo but if it does the.d.tsfile should probably exist alongside. Also if you're doing this you probably should have a plain.tsfile instead.foo.xyz.ts- I'm unsure why you'd write this but it would be broken by this regex change. Maybe some libraries make this common or some repos do this?
If you'd like me to look into a better way, I can.
There was a problem hiding this comment.
I decided I may as well push a fix for foo.xyz.ts. See "Add explicit isDTS detection"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: I have an alias written as
"@utils": ["./src/utils/index.d.mts"]and it was being changed to./src/utils/index.d.mjswhich broke resolution.I know it's obviously niche to be using tsc-alias on already written
.d.tsfiles but I'm of course typing someone else's code so plain.tsfiles don't make sense. I can see a few alternatives here:noRewritePathsor something..d.mtsand.d.mjsBut I think this solution is pretty simple!