Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background color parsing #276

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

FauconSpartiate
Copy link
Contributor

Fixes #234
A typo made the background color parsing return always null

Copy link
Owner

@justkawal justkawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eagle's Eye @FauconSpartiate
Good catch

Approved LGTM

@FauconSpartiate FauconSpartiate merged commit 039c66f into justkawal:main Oct 29, 2023
1 check passed
@FauconSpartiate FauconSpartiate deleted the background_color branch October 29, 2023 08:59
@Daybayzayd
Copy link

Is this fix published in the last pub.dev version ?
Because i have always null when i try and i have the latest version installed.

@FauconSpartiate
Copy link
Contributor Author

@Daybayzayd nope, hasn't been released, should be done someday, indeed 😅

@Daybayzayd
Copy link

@FauconSpartiate No problem, i discovered the functionnality allowing me to add a github repository as a dependency in my pubspec.yaml thanks to this problem. :D

@justkawal
Copy link
Owner

Released yesterday I guess…. Haha

Try the version:

excel: ^4.0.0

@justkawal
Copy link
Owner

Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backgroundColorHex issue
3 participants