Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CellIndex, FastList and Formula #275

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Refactor CellIndex, FastList and Formula #275

merged 2 commits into from
Oct 28, 2023

Conversation

sunboyy
Copy link
Contributor

@sunboyy sunboyy commented Oct 28, 2023

  • Replace assert check with non-null constraints
  • Avoid unnecessary use of late keyword
  • Avoid unnecessary use of private variables

@FauconSpartiate
Copy link
Contributor

Looks good, but there seem to be some breaking changes to the API?
Could you document them?

@sunboyy
Copy link
Contributor Author

sunboyy commented Oct 28, 2023

Where should I document them?

FauconSpartiate
FauconSpartiate approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@FauconSpartiate FauconSpartiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the changelog is good 👍
LGTM

@FauconSpartiate FauconSpartiate merged commit c3e695b into justkawal:main Oct 28, 2023
1 check passed
@sunboyy sunboyy deleted the refactor branch November 5, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FauconSpartiate FauconSpartiate FauconSpartiate approved these changes

@justkawal justkawal Awaiting requested review from justkawal justkawal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunboyy @FauconSpartiate