Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white-space: nowrap to read-more link #4

Open
demetris opened this issue Mar 25, 2019 · 4 comments
Open

Add white-space: nowrap to read-more link #4

demetris opened this issue Mar 25, 2019 · 4 comments

Comments

@demetris
Copy link

.entry__more-link {
    white-space: nowrap;
}

Also, I see that there is no space between the ellipsis entity and the anchor. Is this deliberate?

@justintadlock
Copy link
Owner

Why add this CSS?

Also, I see that there is no space between the ellipsis entity and the anchor. Is this deliberate?

Different styleguides have different rules on this. I haven't 100% decided whether I want no spaces, thin spaces, or normal spaces before/after. Generally, I follow AP style, which I believe (I need to check) uses spaces before/after.

The only thing I'm for sure on is using … rather than three dots, spaced or unspaced.

@demetris
Copy link
Author

Without the nowrap you get a hanging arrow sometimes.

In general, I don't mind widow words in web typography, but a widow arrow bugs me immensely.

If you want to avoid the widow, it would be perhaps be better to just attach the arrow to the previous word, but I am not fond of any of the options for doing that: non-breaking space, extra span, or JavaScript.

So I'm suggesting to add nowrap to the element that is already there.

@justintadlock
Copy link
Owner

Not wrapping the entire more link has its own problems, such as having a huge chunk of text missing from the previous line.

A non-breaking space would probably be most appropriate. I think I'd rather do this since we have direct control over the text.

justintadlock added a commit that referenced this issue Mar 27, 2019
@demetris
Copy link
Author

A non-breaking space would probably be most appropriate.

Yeah. On second thought, the non-breaking space seems fine to me too.

I think I would prefer adding nowrap to the whole link because I see this particular link more like a button.

If you see it as what it really is, a link, then the non-breaking space is more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants