Add support for German and French quotes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livibetter
reviewed
Feb 12, 2018
There was a problem hiding this comment.
I would suggest also writing tests.
Pinging @leohemsted, just in case you ain't aware of this PR and you ain't watching your own repo.
| @@ -197,6 +204,7 @@ def smartypants(text, attr=None): | |||
|
|
|||
| do_quotes = attr & Attr.q | |||
| do_backticks = attr & Attr.mask_b | |||
| do_commas = attr & Attr.c | |||
There was a problem hiding this comment.
This is quite ambiguous, shouldn't be "German" and "French" in the name?
There was a problem hiding this comment.
I would name it something like do_quotes_de.
| @@ -49,6 +49,13 @@ class for instantiation of module attribute :attr:`Attr`. | |||
| """ | |||
| mask_b = b | B | |||
|
|
|||
| c = 1 << 10 | |||
| """ | |||
| flag for comma quotes (``,,``) and (``````) to curly ones. | |||
There was a problem hiding this comment.
Need to mention what they are for: German-style quotes.
|
By the way, @leohemsted, have you figured out any alternatives of PyPI docs hosting? You will need to find one or new features like this would be hard to be aware of, because no one would really dig into library codes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement converting:
,,German style quotes``→ „German style quotes“<<French style quotes>>→ «French style quotes»Inspired by the PHP implementation.