fix(linter): resolve file path for the black linter to avoid a bug in black file path handling

.lintrunner.toml

@@ -166,7 +166,7 @@ init_command = [
     'run',
     'pip_init',
     '--dry-run={{DRYRUN}}',
-    'black==22.10.0',
+    'black==24.1.1',
     'isort==5.10.1',
 ]
 is_formatter = true

lintrunner_adapters/adapters/black_isort_linter.py

@@ -1,4 +1,4 @@
 """Format file with black and isort."""
 
 # PyTorch LICENSE. See LICENSE file in the root directory of this source tree.
 
@@ -12,7 +12,7 @@
 import sys
 
 import lintrunner_adapters
-from lintrunner_adapters import LintMessage, LintSeverity, as_posix, run_command
+from lintrunner_adapters import LintMessage, LintSeverity, as_posix
 
 LINTER_CODE = "BLACK-ISORT"
 
@@ -24,22 +24,22 @@
     *,
     fast: bool = False,
 ) -> list[LintMessage]:
+    del retries  # Unused
+
     try:
         with open(filename, "rb") as f:
             original = f.read()
         with open(filename, "rb") as f:
             # Run isort first then black so we get consistent result
             # even if isort is not using the black profile
-            proc = run_command(
+            proc = subprocess.Popen(
                 [sys.executable, "-misort", "-"],
                 stdin=f,
-                retries=retries,
-                timeout=timeout,
-                check=True,
+                stdout=subprocess.PIPE,
+                stderr=subprocess.PIPE,
             )
-            import_sorted = proc.stdout
-            # Pipe isort's result to black
-            proc = run_command(
+            # Launch second process and connect it to the first one
+            black_proc = subprocess.Popen(
                 [
                     sys.executable,
                     "-mblack",
@@ -50,12 +50,14 @@
                     filename,
                     "-",
                 ],
-                stdin=None,
-                input=import_sorted,
-                retries=retries,
-                timeout=timeout,
-                check=True,
+                stdin=proc.stdout,
+                stdout=subprocess.PIPE,
+                stderr=subprocess.PIPE,
             )
+
+            # Let stream flow between them
+            replacement, _ = black_proc.communicate(timeout=timeout)
+
     except subprocess.TimeoutExpired:
         return [
             LintMessage(
@@ -81,7 +83,7 @@
                 line=None,
                 char=None,
                 code=LINTER_CODE,
-                severity=LintSeverity.ADVICE,
+                severity=LintSeverity.ERROR,
                 name="command-failed",
                 original=None,
                 replacement=None,
@@ -103,7 +105,6 @@
             )
         ]
 
-    replacement = proc.stdout
     if original == replacement:
         return []