fix: prevent buffer jump when safe strategy fails #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `replace-buffer-contents` fails to do a non-destructive replacement within the allotted time/cost, it basically follows the `fast` strategy, except unlike the `fast` strategy, it doesn't try to prevent the window from jumping. So in addition to doing the window adjustment in the `fast` strategy, we also do it for the `safe` strategy when it fails and returns `nil`.
|
Hey, this looks great. Thanks for the PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
replace-buffer-contentsfails to do a non-destructive replacement within the allotted time/cost, it basically follows thefaststrategy, except unlike thefaststrategy, it doesn't try to prevent the window from jumping.So in addition to doing the window adjustment in the
faststrategy, we can also do it for thesafestrategy when it fails and returnsnil.