You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 17, 2023. It is now read-only.
I personally believe it would not be a good idea, or it should be an option disabled by default.
You say in the README it is a "peaceful builder": therefore the goal should be to be quiet when everything is fine. Once errors are cleaned, the comments are hidden by github, but a PR level comment would still be visible -- i don't think this serves a purpose.
The purpose it serves is to let you know that the tool was run at all. I
find it hard to remember which PRs I've run it on and which I haven't.
On Feb 18, 2014 4:35 AM, "Neamar" [email protected] wrote:
I personally believe it would not be a good idea, or it should be an
option disabled by default.
You say in the README it is a "peaceful builder": therefore the goal
should be to be quiet when everything is fine. Once errors are cleaned, the
comments are hidden by github, but a PR level comment would still be
visible -- i don't think this serves a purpose.
Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-35379949
.
One good way to do that would be to have a Github hook linting on every push, just like some CI services do. Once #37 is fixed i would be really interested to develop such a tool using imhotep -- that way you don't need to remember if you've linted it or not.
Anyway regarding this issue, you're probably right -- however it would be super cool to have a flag to disable this behavior ;)
Just a mini-report saying what ran, total violations, etc.
The text was updated successfully, but these errors were encountered: