Skip to content
This repository has been archived by the owner on Jun 17, 2023. It is now read-only.

imhotep should say as a PR level comment which linters were run. #49

Open
justinabrahms opened this issue Feb 10, 2014 · 3 comments
Open

Comments

@justinabrahms
Copy link
Owner

Just a mini-report saying what ran, total violations, etc.

@Neamar
Copy link

Neamar commented Feb 18, 2014

I personally believe it would not be a good idea, or it should be an option disabled by default.

You say in the README it is a "peaceful builder": therefore the goal should be to be quiet when everything is fine. Once errors are cleaned, the comments are hidden by github, but a PR level comment would still be visible -- i don't think this serves a purpose.

@justinabrahms
Copy link
Owner Author

The purpose it serves is to let you know that the tool was run at all. I
find it hard to remember which PRs I've run it on and which I haven't.
On Feb 18, 2014 4:35 AM, "Neamar" [email protected] wrote:

I personally believe it would not be a good idea, or it should be an
option disabled by default.

You say in the README it is a "peaceful builder": therefore the goal
should be to be quiet when everything is fine. Once errors are cleaned, the
comments are hidden by github, but a PR level comment would still be
visible -- i don't think this serves a purpose.

Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-35379949
.

@Neamar
Copy link

Neamar commented Feb 18, 2014

That's right.

One good way to do that would be to have a Github hook linting on every push, just like some CI services do. Once #37 is fixed i would be really interested to develop such a tool using imhotep -- that way you don't need to remember if you've linted it or not.

Anyway regarding this issue, you're probably right -- however it would be super cool to have a flag to disable this behavior ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants