-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] – Switch to dart-sass #globalconfig #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinrodrigues
commented
Feb 8, 2022
e14e867
to
498a238
Compare
032d5f8
to
55e706f
Compare
76388b9
to
ce30e88
Compare
ashleynolan
reviewed
Feb 15, 2022
dandel10n
reviewed
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny question about version bump, other than that looks good to me
oliversweb
approved these changes
Feb 15, 2022
DamianMullins
approved these changes
Feb 15, 2022
kevinrodrigues
commented
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks alot for picking this up whilst I was away @ashleynolan 🎖️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
atoms
This PR changes at least one "atom" component
molecules
This PR changes at least one "molecule" component
organisms
This PR changes at least one "organism" component
pages
This PR changes at least one "page" component
services
This PR changes at least one "service" package
storybook
This PR contains storybook changes
templates
This PR changes at least one "template" component
tools
This PR changes at least one "tool"
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
dart-sass
instead ofnode-sass
for styles.There is still an outstanding issue in
vue-jest
and it's support of dart-sass which means for componentswanting to compile styles in jest (to test classnames for instance),
node-sass
still needs to be includedas part of that packages
devDepenedencies
. For all other packages,experimentalCSSCompile: false
has beenset to turn off jest compiling styles, otherwise the tests won't run as expected.
sass-loader
's node_modules path resolution, as this comes out of the box.Removed
$theme
variables incommon.scss
files, as no longer needed.~
for fozzie scss refrences, as not needed – sass-loader does this automatically now.