Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1 #8

Merged
merged 13 commits into from
Oct 1, 2020
Merged

Closes #1 #8

merged 13 commits into from
Oct 1, 2020

Conversation

tumb1er
Copy link
Collaborator

@tumb1er tumb1er commented Oct 1, 2020

This PR implements new broker-side backoff mechanics that is covered with tests

@tumb1er tumb1er added the enhancement New feature or request label Oct 1, 2020
@tumb1er tumb1er added this to the 0.0.3 milestone Oct 1, 2020
@tumb1er tumb1er requested a review from ttyS15 October 1, 2020 09:36
@codecov-commenter
Copy link

Codecov Report

Merging #8 into master will increase coverage by 7.58%.
The diff coverage is 94.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   86.48%   94.06%   +7.58%     
==========================================
  Files           4        8       +4     
  Lines         185      489     +304     
==========================================
+ Hits          160      460     +300     
- Misses         25       29       +4     
Flag Coverage Δ
#unittests 94.06% <94.38%> (+7.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
amqp_events/config.py 80.00% <ø> (ø)
demo/tasks.py 83.33% <90.00%> (ø)
demo/tests.py 93.66% <91.81%> (-6.34%) ⬇️
amqp_events/celery.py 99.17% <99.15%> (ø)
amqp_events/task.py 100.00% <100.00%> (ø)
demo/celery.py 100.00% <100.00%> (ø)
demo/events.py 58.33% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9cf20...66225b7. Read the comment docs.

@ttyS15
Copy link

ttyS15 commented Oct 1, 2020

👍

Could you move #1 (comment) into README or just refer to it. This comment describes the concept clearly.

@tumb1er tumb1er merged commit 57f9d80 into master Oct 1, 2020
@tumb1er tumb1er deleted the backoff branch October 1, 2020 15:15
@tumb1er tumb1er linked an issue Oct 1, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exponential backoff problem
3 participants