Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tracing crate for nix-health’s output? #27

Closed
shivaraj-bh opened this issue Jul 11, 2024 · 2 comments · Fixed by #28
Closed

Use tracing crate for nix-health’s output? #27

shivaraj-bh opened this issue Jul 11, 2024 · 2 comments · Fixed by #28
Labels
enhancement New feature or request

Comments

@shivaraj-bh
Copy link
Member

This change would provide fine-grained control over the verbosity of the nix-health output
@shivaraj-bh
Copy link
Member Author

Additionally, downstream packages like nixci can use this to control the stream that the output is printed on.

@srid
Copy link
Member

srid commented Jul 11, 2024 •
edited
Loading

Yes, that'd be good to do. How well does it operate with colours/ emojis?

@srid srid added the enhancement New feature or request label Jul 11, 2024
@srid srid mentioned this issue Jul 11, 2024
Closed
shivaraj-bh added a commit to shivaraj-bh/nix-health that referenced this issue Jul 11, 2024
@shivaraj-bh
feat: println -> tracing
23433c1 
resolves juspay#27
@shivaraj-bh shivaraj-bh mentioned this issue Jul 11, 2024
Merged
@srid srid closed this as completed in #28 Jul 12, 2024
srid pushed a commit that referenced this issue Jul 12, 2024
@shivaraj-bh
feat: Send all output to stderr; make -q less verbose (#28)
574e7c4 
resolves #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Send all output to stderr; make -q less verbose shivaraj-bh/nix-health
2 participants
@srid @shivaraj-bh