Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): move router data flow types to hyperswitch domain models crate #4801

Merged
merged 4 commits into from
May 30, 2024
Merged

refactor(core): move router data flow types to hyperswitch domain models crate #4801

merged 4 commits into from
May 30, 2024

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

moved router data flow types to hyperswitch domain models crate

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

How did you test it?

Checked if the code compiles successfully.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels May 29, 2024
@hrithikesh026 hrithikesh026 added this to the May 2024 Release milestone May 29, 2024
@hrithikesh026 hrithikesh026 self-assigned this May 29, 2024
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner May 29, 2024 06:33
Narayanbhat166
Narayanbhat166 previously approved these changes May 29, 2024
View reviewed changes
Base automatically changed from move-router-data-response-models-to-hyperswitch-domain-model to main May 29, 2024 08:13
@likhinbopanna likhinbopanna dismissed Narayanbhat166’s stale review May 29, 2024 08:13

The base branch was changed.

@hrithikesh026 hrithikesh026 requested review from a team as code owners May 29, 2024 08:13
@preetamrevankar preetamrevankar added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 61e67e4 May 30, 2024
10 checks passed
@preetamrevankar preetamrevankar deleted the move-router-data-flow-types-to-hyperswitch-domain-models branch May 30, 2024 15:09
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@hrithikesh026 hrithikesh026

Labels
C-refactor Category: Refactor
Projects
None yet
Milestone
May 2024 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@hrithikesh026 @SanchithHegde @Narayanbhat166 @preetamrevankar