refactor(FRM): refactor frm configs

[srujanchikke]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

This PR contains

1. Depricating FRM action and rule setting on hyperswitch end.
2. revising the new FRM configs
3. Taking actions based on frm status .
4. Few bugs of previous PR described here.
5. provided backward compatability for previous configs.

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Previously frm configuration when creating merchant connector for FRM connector used to be like

"frm_configs": [
        {
            "gateway": "stripe",
            "payment_methods": [
                {
                    "payment_method": "card",
                    "payment_method_types": [
                        {
                            "payment_method_type": "credit",
                            "card_networks": [
                                "Visa"
                            ],
                            "flow": "post",
                            "action": "cancel_txn"
                        },
                        {
                            "payment_method_type": "debit",
                            "card_networks": [
                                "Visa"
                            ],
                            "flow": "post",
                            "action": "manual_review"
                        }
                    ]
                }
            ]
        }
    ]

This has been modified to

"frm_configs": [
        {
            "gateway": "stripe",
            "payment_methods": [
                {
                    "payment_method": "card",
                    "flow": "post"
                },
                {
		                "payment_method": "wallet",
                    "flow": "pre"
                }
            ]
        }
    ]

Motivation and Context

Frm action is depricated because the levarage of manual review now has been moved to frm connector. We consume webhooks from frm connectors and take appropriate action. We also depricated merchant to configure rules from hyperswitch end since he already sets up rules in frm, so we solely depends on FRM status to take action.

PreAuth flow :

• FRAUD -> Cancel Payment
• LEGIT -> Continue transaction
• MANUAL_REVIEW -> We don't support Manual review since there will be no customer for completing the payment.

PostAuth flow :

• FRAUD -> Cancel Payment
• LEGIT -> continue transaction
• MANUAL_REVIEW -> Approve/ Decline based on webhook recieved from frm connector.

How did you test it?

Test merchant account create with both new and old frm configs.

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[Narayanbhat166]

Can you add some test coverage for FRM? can be taken up in subsequent PRs

[Narayanbhat166]

Suggested change

	#[schema(value_type = FrmPreferredFlowTypes)]
	#[schema(value_type = Option<FrmPreferredFlowTypes>)]

[Narayanbhat166]

Suggested change

	///frm flow type to be used...can be pre/post
	///frm flow type to be used, can be pre/post

[Narayanbhat166]

do we validate the value here? or any serde_json::value can be put in the column?

[srujanchikke]

No we don't validate here, validation is there at connector level. Signifyd & Riskified expects few fields from frm_metadata.

[Narayanbhat166]

Suggested change

	ALTER TABLE payment_intent ADD COLUMN frm_metadata JSONB DEFAULT NULL;
	ALTER TABLE payment_intent ADD COLUMN IF NOT EXISTS frm_metadata JSONB DEFAULT NULL;

[Narayanbhat166]

Suggested change

	ALTER TABLE payment_intent DROP COLUMN frm_metadata;
	ALTER TABLE payment_intent DROP COLUMN IF EXISTS frm_metadata;

[apoorvdixit88]

Dashboard specific changes are fine!