Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Multi filters support #79

Merged
merged 56 commits into from
Jan 3, 2024
Merged

feat: Multi filters support #79

merged 56 commits into from
Jan 3, 2024

Conversation

sagarnaikjuspay
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay self-assigned this Dec 7, 2023
@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner December 7, 2023 19:26
JeevaRamu0104
JeevaRamu0104 reviewed Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@JeevaRamu0104 JeevaRamu0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please recheck the functionality

@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 28, 2023
JeevaRamu0104
JeevaRamu0104 reviewed Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@JeevaRamu0104 JeevaRamu0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Add trim in the payment_id search field

src/context/FilterContext.res Outdated Show resolved Hide resolved
src/context/FilterContext.res Outdated Show resolved Hide resolved
src/context/FilterContext.res Outdated Show resolved Hide resolved
@JeevaRamu0104 JeevaRamu0104 added S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jan 3, 2024
@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jan 3, 2024
@JeevaRamu0104 JeevaRamu0104 merged commit fd1aa3d into main Jan 3, 2024
4 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the multi-filters-support branch January 3, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainlokesh318 jainlokesh318 jainlokesh318 left review comments

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 left review comments

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@vsrivatsa-edinburgh vsrivatsa-edinburgh vsrivatsa-edinburgh left review comments

Assignees

@sagarnaikjuspay sagarnaikjuspay

Labels
S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sagarnaikjuspay @Riddhiagrawal001 @jainlokesh318 @JeevaRamu0104 @vsrivatsa-edinburgh