Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signin password check removed #1106

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: signin password check removed #1106

merged 2 commits into from
Aug 2, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 commented Aug 2, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Signin is checking for password which should not be validated
image

Motivation and Context

How did you test it?

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed user-management Status: issues related to user management labels Aug 2, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Aug 2, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner August 2, 2024 08:44
@Riddhiagrawal001 Riddhiagrawal001 linked an issue Aug 2, 2024 that may be closed by this pull request
[BUG] Password validation in login page #1107
Closed
@PritishBudhiraja PritishBudhiraja added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 1858350 Aug 2, 2024
5 of 6 checks passed
@PritishBudhiraja PritishBudhiraja deleted the password-validation-check branch August 2, 2024 09:10
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed user-management Status: issues related to user management labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Password validation in login page
3 participants
@Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104