Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor code, attach expres async router, fix typescript issues #9

Merged

Conversation

anahit42
Copy link
Member

@anahit42 anahit42 commented Aug 28, 2024

Description

  • a lot of code is just moved to separate files for readability
  • the server lacked basic routing practices we use, it had old code style etc.
  • refactored to more or less similar structure
  • fixed issue with bullmq typings

This is a

  • Bug Fix
  • Feature
  • Documentation
  • Other

Checklists

Commit style

  • Changes are on a branch with a descriptive name eg. fix/missing-queue, docs/setup-guide

  • Commits start with one of feat: fix: docs: chore: or similar

  • No excessive commits, eg: there should be no fix: commits for bugs that existed only on the PR branch (see guide-to-interactive-rebasing)

Protected files

The following files should not change unless they are directly a part of your change.

  • yarn.lock (unless package.json is also modified, then only the new/updated package should be changed here)

  • package.json (renovate bot should handle all routine updates)

  • package-lock.json (Should not exist as this project uses yarn)

  • tsconfig.json (only make it stricter, making it more lenient requires more discussion)

  • tslint.json (only make it stricter, making it more lenient requires more discussion)

Copy link

@thiago-juro thiago-juro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anahit42 anahit42 merged commit 9cce5fb into master Aug 29, 2024
2 checks passed
@anahit42 anahit42 deleted the PLFM-1405-fix-bullmq-exporter-after-bull-version-upgrade branch August 29, 2024 04:27
@anahit42 anahit42 mentioned this pull request Aug 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants