Remove BPlusTree class from @lumino/collections
#345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afshin
changed the title
BPlusTree class from @lumino/collections
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
BPlusTreeclass from@lumino/collections. Its primary use was the@lumino/datastorepackage. It also does not have any unit tests, which we would have needed to add if we wanted to maintain it long-term.If someone wants to use it, they can either access it from Lumino 1.x packages or they can copy/vendor the source code itself as it is contained within one file: https://github.com/jupyterlab/lumino/blob/1.x/packages/collections/src/bplustree.ts