Use for...of instead of each() in disposable

jupyterlab · Aug 15, 2022 · 89f9a77 · 89f9a77
1 parent ec648c0
commit 89f9a77
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/packages/disposable/package.json b/packages/disposable/package.json
@@ -40,7 +40,6 @@
     "watch": "tsc --build --watch"
   },
   "dependencies": {
-    "@lumino/algorithm": "^1.9.1",
     "@lumino/signaling": "^1.10.1"
   },
   "devDependencies": {

diff --git a/packages/disposable/src/index.ts b/packages/disposable/src/index.ts
@@ -7,8 +7,6 @@
 |
 | The full license is in the file LICENSE, distributed with this software.
 |----------------------------------------------------------------------------*/
-import { each } from '@lumino/algorithm';
-
 import { ISignal, Signal } from '@lumino/signaling';
 
 /**
@@ -198,9 +196,9 @@ export namespace DisposableSet {
    */
   export function from(items: Iterable<IDisposable>): DisposableSet {
     let set = new DisposableSet();
-    each(items, item => {
+    for (const item of items) {
       set.add(item);
-    });
+    }
     return set;
   }
 }
@@ -250,9 +248,9 @@ export namespace ObservableDisposableSet {
    */
   export function from(items: Iterable<IDisposable>): ObservableDisposableSet {
     let set = new ObservableDisposableSet();
-    each(items, item => {
+    for (const item of items) {
       set.add(item);
-    });
+    }
     return set;
   }
 }