Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cleanup #5099

Merged
merged 4 commits into from
Aug 14, 2018
Merged

Build cleanup #5099

merged 4 commits into from
Aug 14, 2018

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Aug 11, 2018

Fixes #5017

  • Do not cache during uglify on Windows to avoid creating long paths
  • Use dev_mode by default when building (but ship prod mode files)
  • Run the test builds directly, since a failing TS build does not stop the build, cf bail option does not exit the process codymikol/karma-webpack#66. Fixes the errors that running the builds directly exposed.
  • Display the version and app directory when building

@blink1073
Copy link
Contributor Author

blink1073 commented Aug 12, 2018

CI is being really mean today:

error Couldn't find package "@phosphor/algorithm@^1.1.2" required by "@jupyterlab/apputils@^0.17.2" on the "npm" registry.

(oh rly?: https://www.npmjs.com/package/@phosphor/algorithm. Ugh...)

@blink1073
Copy link
Contributor Author

Pip installs are also failing randomly:

+pip install -q -e '.[test]'
Command "/home/travis/virtualenv/python2.7.14/bin/python -c "import setuptools, tokenize;__file__='/home/travis/build/jupyterlab/jupyterlab/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" develop --no-deps" failed with error code 1 in /home/travis/build/jupyterlab/jupyterlab/

@blink1073 blink1073 self-assigned this Aug 13, 2018
@ian-r-rose
Copy link
Member

Hm, needs a rebase?

@blink1073
Copy link
Contributor Author

Rebased.

@ian-r-rose
Copy link
Member

Thanks!

@ian-r-rose ian-r-rose merged commit 1361c0f into jupyterlab:master Aug 14, 2018
@blink1073 blink1073 deleted the build-cleanup branch September 4, 2018 09:33
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Quality of Life Improvements
2 participants