make strings localizable

[JessicaBarh]

No description provided.

[github-actions]

👈 Launch a binder notebook on branch JessicaBarh/jupyterlab-git/add-i18n

[fcollonval]

Thanks for starting this @JessicaBarh

I left a few comment.

To quickly correct linter errors, you can run locally jlpm run eslint. And to check it jlpm run eslint:check.

[JessicaBarh]

Thanks for your comments @fcollonval. I'm not to familiar with the test files so please let me know what I can modify if needed.

[fcollonval]

Awesome work @JessicaBarh Thanks a lot for it.

Regarding the tests, we can directly use the nullTranslator - as we are not testing the translator. I made suggestions in that sense.

@goanpeca I would appreciate a review from you on this one.

[goanpeca]

Looking into it now. Thanks a lot @JessicaBarh !

[goanpeca]

Hi @JessicaBarh. Great work. there are some things that need to change like `-> ' and some places where it is better to combine into a full string as some languages might have different opinions on the ordering of sentences.

Finally translation will not work on variables so we need to either apply trans to actual strings or handle that wherever those strings are generated.

Thanks a lot for working on this!

[JessicaBarh]

Thanks for pointing these things out @goanpeca!
So if I had the case where:

plural = number_of_files > 1 ? 's' : ''
label: 'Show file${plural}'

What would be the best approach here to make label localizable?

[fcollonval]

Thanks a lot for this PR @JessicaBarh

@goanpeca thank you too to take the time for reviewing the PR

[goanpeca]

Hi @JessicaBarh

this is merged now, but to answer your question:

plural = number_of_files > 1 ? 's' : ''
label: 'Show file${plural}'

What would be the best approach here to make label localizable?

label: trans._n('Show file', 'Show files', number_of_files)

Thanks!