-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow commit & push
#887
Allow commit & push
#887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ktaletsk
I added some suggestion to have a better API.
dac4f2d
to
3aa6b48
Compare
@meeseeksdev backport to jlab-2 |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
…ab-2 Backport PR #887: Allow `commit & push`
Implements #837
So, here's my take on enabling 'Commit and push' in place of 'Commit' button. I pass branch information along with boolean flag to GitCommitBox so that it can render 'Commit and Push' or display the error hint when applicable. Push action is added on the back of
GitPanel.commitStagedFiles
. There is also a new flag in extension settings to enable/disable this behavior.Please, check the code and if it doesn't make sense, I am open to rewriting it.