-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format code using black #763
Conversation
Tests fail because black is not available on python 3.5. This can be worked around with some if statements but it seems to get a little bit ugly as github actions don't support line level if statements. Given that python 3.5 is at the end of life in 9 days (september 13) I propose dropping it from the tests. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ianhi
I agree with you. We can drop testing against 3.5 and I went ahead by adding 3.9rc.
I reorganize a bit the CI script so only jupyterlab needs to be explicitly installed before the test step (to get jlpm
).
@@ -0,0 +1,2 @@ | |||
# migrate code to black | |||
f922e2e1e60e3a964dbd07597e7c44c068b7ba1d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
@meeseeksdev backport to 0.11.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
closes: #728
black .
black . --check
to github actions@mlucool @fcollonval