Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submodules unhandler error #1191

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Fix submodules unhandler error #1191

merged 3 commits into from
Nov 28, 2022

Conversation

seignovert
Copy link
Contributor

Unfortunately it seems that #1188 introduced a Unhandled error 😞

Uncaught exception POST /git/clone?1669638844222 (127.0.0.1)
    HTTPServerRequest(protocol='http', host='localhost:8888', method='POST', uri='/git/clone?1669638844222', version='HTTP/1.1', remote_ip='127.0.0.1')
    Traceback (most recent call last):
      File ".../site-packages/tornado/web.py", line 1713, in _execute
        result = await result
      File ".../site-packages/jupyterlab_git/handlers.py", line 92, in post
        data["submodules"],
    KeyError: 'submodules'

This PR should implements a hot fix with the correct clone command handler (I have mainly duplicated the versioning attribute in the TS command model).

You might also need to write a test for the clone TS component (I don't really know how to do it).

Feel free to double check and edit this PR if needed. My apologies for not spotting this earlier.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch seignovert/jupyterlab-git/fix-submodules-unhandler

@seignovert seignovert changed the title Fix submodules unhandler Fix submodules unhandler error Nov 28, 2022
@fcollonval fcollonval added the bug label Nov 28, 2022
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly fixing this

@fcollonval fcollonval merged commit c8d9481 into jupyterlab:master Nov 28, 2022
@seignovert seignovert deleted the fix-submodules-unhandler branch November 28, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants