add current branch name on status bar #1131
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
|
There was a problem hiding this comment.
Thanks @BoscoCHW
Added current branch name on the status bar I managed to style it but I'm not sure how to center the text vertically. I should make the parent element a flex box and do align-item: center but I don't know how to select the parent class. Also I'm not sure how to change the padding of the git icon so that the text could be closer to the icon.
You can add a class in StatusWidget (the parent element) within the constructor by adding the following line:
this.addClass('jp-git-StatusWidget')Note: by design it is not possible to select parent of an element with CSS selectors.
Another issue is when navigate to another repo (change file directory), the branch name stays unless you click on the git extension icon on the left menu bar, which is a bit weird.
The default behavior is to not refresh the Git model status when the sidebar is hidden to avoid useless calls to the backend. You could solve this by forcing refreshing the branch calling GitExtension.refreshBranch when we set a new repository.
src/components/StatusWidget.tsx
Outdated
| {this._model.currentBranch && ( | ||
| <span className={currentBranchClass}> | ||
| {this._model.currentBranch.name}* | ||
| </span> | ||
| )} |
There was a problem hiding this comment.
You should place this outside the UseSignal component as it does not need to be refreshed if the credentials status of the extension changes.
But you should wrap it in another UseSignal component to listen to this._model.headChanged to react when the git head is changed.
|
I managed to style the status widget by adding a class like you suggested, but I was unable to reduce the right-padding of the git icon on the status bar because I'm afraid overriding the pre-set would lead to unexpected results. |
| )} | ||
| </UseSignal> | ||
|
|
||
| <UseSignal signal={this._model.headChanged}> |
|
Thanks for the update @BoscoCHW
Let's discuss that on Thursday's meeting. |
Co-authored-by: Frédéric Collonval <[email protected]>
Fixes #1100
@fcollonval
Added current branch name on the status bar
I managed to style it but I'm not sure how to center the text vertically.
I should make the parent element a flex box and do align-item: center but I don't know how to select the parent class.
Also I'm not sure how to change the padding of the git icon so that the text could be closer to the icon.
Another issue is when navigate to another repo (change file directory), the branch name stays unless you click on the git extension icon on the left menu bar, which is a bit weird.
Edited to link the related issue.