No Git history for selected file

[willyyang]

Description

Unable to view Git history for a selected file. Implemented in 02c6d9a for #864

Reproduce

1. Clone an active repo
2. Right click on a file (containing history) and navigate to Git -> History
3. No history found shows on file

Expected behavior

Expect to view a number of Git history commits based on the value set for historyCount under advanced settings (kept default of 25)

Context

# cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 10 (buster)"

# pip list | grep jupyterlab-git
jupyterlab-git         0.32.2

# jupyter labextension list
JupyterLab v3.0.17
  @jupyterlab/git v0.32.2 enabled OK (python, jupyterlab-git)

# jupyter server extension list
  jupyterlab_git enabled
  - Validating jupyterlab_git...
     jupyterlab_git 0.32.2 OK

# git --version
git version 2.20.1

[adammclaurin]

@navn-r fyi

[navn-r]

Thanks @willyyang for pointing out the issue and thanks @adammclaurin for pinging me on it.

The bug is definitely reproducible on my side. One thing to note that is the file history works when right clicking on the file in the Git Panel. But you'd need to have modified the file in order to do so, so I can't say to do that as a fix/workaround.

I've found that doing something like this internally should do the trick.

git -C cloned-repo-folder log ...

-C is the flag to specify the exact git folder, source

I'd be more than glad to get a PR in for it. @fcollonval is there any other approach we could take? Considering the regular repository history works as intended.

[fcollonval]

Hey @willyyang thanks for reporting the bug. Could you confirm the workflow leading to the bug?

1. Clone a repository using the Git menu or Git clone button of the filebrowser
2. Navigate inside the cloned repository with the filebrowser
3. Right-click on a file and select the context menu entry Git -> History
4. The Git history panel appears but it displays an error instead of the expected file history

Are you using the standard file browser or a custom extension?

[willyyang]

Hey @fcollonval , I'm using the standard file browser .
For 4, there is no error displayed just No history found.

[fcollonval]

Hey @fcollonval , I'm using the standard file browser .
For 4, there is no error displayed just No history found.

Thanks for the quick answer. I pushed a fix.

[willyyang]

Thanks for the quick fix @fcollonval . I see a new release tag has been cut, when will this change be published?

[fcollonval]

Initially I wanted to do a release right away. But the new merge conflict view (that is part of master) is not ready yet for publication (remaining tasks are tracked in #1031).

But I may branch out to cut a patch release for this one.

[fcollonval]

@willyyang I released 0.32.3 with the fix.