Skip to content

Refactor DocumentRoom, throttle saves instead of debouncing saves #1382

Refactor DocumentRoom, throttle saves instead of debouncing saves

Refactor DocumentRoom, throttle saves instead of debouncing saves #1382

Triggered via pull request March 20, 2024 20:33
Status Failure
Total duration 14m 3s
Artifacts 3

test.yml

on: pull_request
Run pre-commit hook
3m 13s
Run pre-commit hook
Test JavaScript
2m 24s
Test JavaScript
Matrix: Test Python
Install from SDist and Test
1m 23s
Install from SDist and Test
Fit to window
Zoom out
Zoom in

Annotations

11 errors, 27 warnings, and 1 notice
tests/collaborationpanel.spec.ts:29:5 › collaboration panel should contains two items: ui-tests/tests/collaborationpanel.spec.ts#L41
1) tests/collaborationpanel.spec.ts:29:5 › collaboration panel should contains two items ───────── Error: Screenshot comparison failed: 1766 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/test-results/tests-collaborationpanel-collaboration-panel-should-contains-two-items/collaborationPanelCollapsed-expected.png Received: /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/test-results/tests-collaborationpanel-collaboration-panel-should-contains-two-items/collaborationPanelCollapsed-actual.png Diff: /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/test-results/tests-collaborationpanel-collaboration-panel-should-contains-two-items/collaborationPanelCollapsed-diff.png 39 | } 40 | } > 41 | expect(await panel.screenshot()).toMatchSnapshot( | ^ 42 | 'collaborationPanelCollapsed.png' 43 | ); 44 | at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:41:36
tests/collaborationpanel.spec.ts:178:7 › Three clients › Without document: ui-tests/tests/collaborationpanel.spec.ts#L187
2) tests/collaborationpanel.spec.ts:178:7 › Three clients › Without document ───────────────────── Error: Screenshot comparison failed: 3373 pixels (ratio 0.02 of all image pixels) are different. Expected: /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/test-results/tests-collaborationpanel-Three-clients-Without-document/three-client-without-document-expected.png Received: /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/test-results/tests-collaborationpanel-Three-clients-Without-document/three-client-without-document-actual.png Diff: /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/test-results/tests-collaborationpanel-Three-clients-Without-document/three-client-without-document-diff.png 185 | 186 | const tab = await page.sidebar.getContentPanel('left'); > 187 | expect(await tab?.screenshot()).toMatchSnapshot( | ^ 188 | 'three-client-without-document.png' 189 | ); 190 | }); at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:187:37
tests/collaborationpanel.spec.ts:192:7 › Three clients › With document: ui-tests/tests/collaborationpanel.spec.ts#L199
3) tests/collaborationpanel.spec.ts:192:7 › Three clients › With document ──────────────────────── Error: Could not find refresh toolbar item 197 | await Promise.all( 198 | guestPages.map(async p => { > 199 | await p.filebrowser.refresh(); | ^ 200 | await p.notebook.open('Untitled.ipynb'); 201 | }) 202 | ); at FileBrowserHelper.refresh (/home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/node_modules/@jupyterlab/galata/src/helpers/filebrowser.ts:211:13) at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:199:9 at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/collaborationpanel.spec.ts:197:5
tests/notebook.spec.ts:104:7 › Initialization › Create a notebook: ui-tests/tests/notebook.spec.ts#L108
4) tests/notebook.spec.ts:104:7 › Initialization › Create a notebook ───────────────────────────── Error: Could not find refresh toolbar item 106 | await page.notebook.createNew(); 107 | await page.notebook.activate(pathUntitled); > 108 | await guestPage.filebrowser.refresh(); | ^ 109 | await guestPage.notebook.open(pathUntitled); 110 | 111 | const nbPanel = await page.notebook.getNotebookInPanel(); at FileBrowserHelper.refresh (/home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/node_modules/@jupyterlab/galata/src/helpers/filebrowser.ts:211:13) at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/notebook.spec.ts:108:5
tests/notebook.spec.ts:127:7 › Initialization › Open a notebook: ui-tests/tests/notebook.spec.ts#L128
5) tests/notebook.spec.ts:127:7 › Initialization › Open a notebook ─────────────────────────────── Error: Could not find refresh toolbar item 126 | 127 | test('Open a notebook', async ({ page }) => { > 128 | await page.filebrowser.refresh(); | ^ 129 | await page.notebook.open(exampleNotebook); 130 | await page.notebook.activate(exampleNotebook); 131 | at FileBrowserHelper.refresh (/home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/node_modules/@jupyterlab/galata/src/helpers/filebrowser.ts:211:13) at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/notebook.spec.ts:128:5
tests/user-menu.spec.ts:20:5 › the top bar should contain the user menu with 2 items: ui-tests/tests/user-menu.spec.ts#L22
6) tests/user-menu.spec.ts:20:5 › the top bar should contain the user menu with 2 items ────────── Error: Timed out 5000ms waiting for expect(received).toHaveCount(expected) // deep equality Expected: 2 Received: 4 Call log: - expect.toHaveCount with timeout 5000ms - waiting for locator('#jp-top-bar > :not(.jp-Toolbar-spacer)') - locator resolved to 4 elements - unexpected value "4" - locator resolved to 4 elements - unexpected value "4" - locator resolved to 4 elements - unexpected value "4" - locator resolved to 4 elements - unexpected value "4" - locator resolved to 4 elements - unexpected value "4" - locator resolved to 4 elements - unexpected value "4" - locator resolved to 4 elements - unexpected value "4" - locator resolved to 4 elements - unexpected value "4" - locator resolved to 4 elements - unexpected value "4" 20 | test('the top bar should contain the user menu with 2 items', async ({ page }) => { 21 | const topBarItems = page.locator('#jp-top-bar > :not(.jp-Toolbar-spacer)'); > 22 | await expect(topBarItems).toHaveCount(2); | ^ 23 | }); 24 | 25 | test('should open dialog when clicking on the shared link button', async ({ page }) => { at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/user-menu.spec.ts:22:29
tests/user-menu.spec.ts:25:5 › should open dialog when clicking on the shared link button: ui-tests/tests/user-menu.spec.ts#L1
7) tests/user-menu.spec.ts:25:5 › should open dialog when clicking on the shared link button ───── Test timeout of 60000ms exceeded.
tests/user-menu.spec.ts:25:5 › should open dialog when clicking on the shared link button: ui-tests/tests/user-menu.spec.ts#L28
7) tests/user-menu.spec.ts:25:5 › should open dialog when clicking on the shared link button ───── Error: locator.screenshot: Target closed =========================== logs =========================== waiting for locator('button[data-command="collaboration:shared-link"]') ============================================================ 26 | const sharedLinkButton = page.locator('button[data-command="collaboration:shared-link"]'); 27 | > 28 | expect(await sharedLinkButton.screenshot()).toMatchSnapshot( | ^ 29 | 'shared-link-icon.png' 30 | ); 31 | at /home/runner/work/jupyter-collaboration/jupyter-collaboration/ui-tests/tests/user-menu.spec.ts:28:33
tests/user-menu.spec.ts:25:5 › should open dialog when clicking on the shared link button: ui-tests/tests/user-menu.spec.ts#L1
7) tests/user-menu.spec.ts:25:5 › should open dialog when clicking on the shared link button ───── Pending operations: - locator.screenshot at tests/user-menu.spec.ts:28:33
tests/user-menu.spec.ts:40:5 › should close the shared link dialog on cancel: ui-tests/tests/user-menu.spec.ts#L1
8) tests/user-menu.spec.ts:40:5 › should close the shared link dialog on cancel ────────────────── Test timeout of 60000ms exceeded.
Test Minimum Versions
Process completed with exit code 1.
check_links
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test JavaScript
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Python (ubuntu-latest, 3.11)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Python (ubuntu-latest, 3.8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Python (ubuntu-latest, 3.12)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run pre-commit hook
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, pre-commit/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run pre-commit hook
The following actions uses node12 which is deprecated and will be forced to run on node16: pre-commit/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Run pre-commit hook: packages/collaboration/src/cursors.ts#L171
Forbidden non-null assertion
Run pre-commit hook: packages/collaboration/src/cursors.ts#L235
Forbidden non-null assertion
Run pre-commit hook: packages/collaboration/src/cursors.ts#L285
Forbidden non-null assertion
Run pre-commit hook: packages/collaboration/src/menu.ts#L65
Forbidden non-null assertion
Run pre-commit hook: packages/collaboration/src/menu.ts#L70
Forbidden non-null assertion
Run pre-commit hook: packages/collaboration/src/menu.ts#L76
Forbidden non-null assertion
Run pre-commit hook: packages/collaboration/src/menu.ts#L78
Forbidden non-null assertion
Run pre-commit hook: packages/collaboration/src/userinfopanel.tsx#L26
Forbidden non-null assertion
Run pre-commit hook: packages/collaboration/src/userinfopanel.tsx#L32
Forbidden non-null assertion
Test Python (windows-latest, 3.11)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Python (windows-latest, 3.8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Python (macos-latest, 3.12)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Python (macos-latest, 3.8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Python (macos-latest, 3.11)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ui_tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make SDist
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Prereleases
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Minimum Versions
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Install from SDist and Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, actions/download-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
🎭 Playwright Run Summary
10 failed tests/collaborationpanel.spec.ts:29:5 › collaboration panel should contains two items ────────── tests/collaborationpanel.spec.ts:178:7 › Three clients › Without document ────────────────────── tests/collaborationpanel.spec.ts:192:7 › Three clients › With document ───────────────────────── tests/notebook.spec.ts:104:7 › Initialization › Create a notebook ────────────────────────────── tests/notebook.spec.ts:127:7 › Initialization › Open a notebook ──────────────────────────────── tests/user-menu.spec.ts:20:5 › the top bar should contain the user menu with 2 items ─────────── tests/user-menu.spec.ts:25:5 › should open dialog when clicking on the shared link button ────── tests/user-menu.spec.ts:40:5 › should close the shared link dialog on cancel ─────────────────── tests/user-menu.spec.ts:47:5 › should copy the shared link in clipboard ──────────────────────── tests/user-menu.spec.ts:58:5 › should copy the shared link with filepath ─────────────────────── 3 skipped 3 passed (5.6m)

Artifacts

Produced during runtime
Name Size
coverage-data Expired
608 KB
jupyter-collaboration-playwright-report Expired
9.98 MB
sdist Expired
7 MB