Resolves chat panel initialization error

[abbott]

Removes get_value({}) inline of dictionary get method, unblocking chat panel initialization error:

“There seems to be a problem with the Chat backend, please look at the JupyterLab server logs or contact your administrator to correct this problem.”

Tested against v2.10.0 in Jupyter Lab v4.1.2

Fixes #335

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[dlqqq]

Thank you opening this PR! Once released, this will be super helpful to other users experiencing the same bug.

This PR is not yet complete however. The root issue is that the value of self.config.serverapp.jpserver_extensions has a different type that depends on the environment for some reason. In some environments (like yours) it is an instance of dict, but in others (like the CI pipeline) it is an instance of LazyConfigValue. See these CI logs:

What's more bizarre is that the value of this LazyConfigValue seems to differ depending on how it is accessed. Here are the logging statements I added to get_chat_user():

self.log.warning(self.config)
self.log.warning(self.config.ServerApp)
self.log.warning(self.config.ServerApp.jp_server_extensions)
self.log.warning(self.config.ServerApp.jp_server_extensions.get_value({}))

And here are the logs they yield:

[W 2024-03-05 10:30:38.298 ServerApp] {'NotebookApp': {}, 'ServerApp': {'jpserver_extensions': <LazyConfigValue value={'jupyterlab': True, 'jupyter_ai': True, 'jupyter_lsp': True, 'jupyter_server_terminals': True, 'notebook_shim': True}>, 'default_url': '/lab', 'open_browser': True, 'file_url_prefix': '/lab/tree', 'jp_server_extensions': <LazyConfigValue value={}>}}
[W 2024-03-05 10:30:38.298 ServerApp] {'jpserver_extensions': <LazyConfigValue value={'jupyterlab': True, 'jupyter_ai': True, 'jupyter_lsp': True, 'jupyter_server_terminals': True, 'notebook_shim': True}>, 'default_url': '/lab', 'open_browser': True, 'file_url_prefix': '/lab/tree', 'jp_server_extensions': <LazyConfigValue value={}>}
[W 2024-03-05 10:30:38.298 ServerApp] <LazyConfigValue value={}>
[W 2024-03-05 10:30:38.299 ServerApp] {}

Notice how line 2 implies a non-empty dict, but lines 3 and 4 imply an empty dict. 🤔

I'm going to pull in @Zsailer to see if he can offer some guidance on the best way of determining if jupyter_collaboration is installed & enabled. There may be a better way that doesn't require accessing self.config.ServerApp.jp_server_extensions directly, since that may be an internal jupyter_server API.

Zach and I will get back to you on this, and I will open a PR against your PR. 👍

[dlqqq]

Awesome work, thank you both! @abbott @Zsailer

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[dlqqq]

@meeseeksdev please backport to 1.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 1.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 60e9161e55304e51e7fa1d08a227bde594d13115

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #660: Resolves chat panel initialization error'

4. Push to a named branch:

git push YOURFORK 1.x:auto-backport-of-pr-660-on-1.x

5. Create a PR against branch 1.x, I would have named this PR:

"Backport PR #660 on branch 1.x (Resolves chat panel initialization error)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[dlqqq]

Disregard the above, that was done out of muscle memory, and this PR should not be backported.