Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chat UI #25

Merged
merged 10 commits into from
Apr 8, 2023
Merged

Implement chat UI #25

merged 10 commits into from
Apr 8, 2023

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Apr 4, 2023

Description

Implements a basic Chat UI on the right sidebar to interact with chat models (currently just ChatGPT). This does not use the WebSockets handler implemented in #40, and instead calls a temporary REST API endpoint for now. Integration with #40 requires further work, as switching chat providers from langchain.llms.openai to langchain.chat_models.openai causes the magics to break. The implementation details of how to handle selection replacement in a multi-user scenario are still too ambiguous at this moment.

Features include:

  • Chat UI in the right sidebar
  • Selection inclusion & replacement
  • Math rendering
  • Code rendering

Demo

Screen.Recording.2023-04-07.at.10.10.02.PM.mov

Next steps

  • Shift-Enter to send, helper text on send button to inform users
  • Migrate to use WebSockets handlers

@dlqqq dlqqq added the enhancement New feature or request label Apr 4, 2023
@dlqqq dlqqq marked this pull request as draft April 4, 2023 18:57
@dlqqq dlqqq marked this pull request as ready for review April 8, 2023 05:18
@dlqqq dlqqq merged commit f4e7cac into jupyterlab:main Apr 8, 2023
@dlqqq dlqqq deleted the chat-ui branch April 8, 2023 05:33
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* implement chat UI

* improve rendering of code blocks

* handle empty and loading state in chat-input

* align all messages to the left

* css tweaks

* add build:core yarn script

* handle user selections

* support math rendering

* keep using old OpenAIChat provider for chat and magics

* delete example messages
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* implement chat UI

* improve rendering of code blocks

* handle empty and loading state in chat-input

* align all messages to the left

* css tweaks

* add build:core yarn script

* handle user selections

* support math rendering

* keep using old OpenAIChat provider for chat and magics

* delete example messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant