Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sagemaker example to make more sense #231

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Change sagemaker example to make more sense #231

merged 3 commits into from
Jun 21, 2023

Conversation

JasonWeill
Copy link
Collaborator

Uses the Flan XL HuggingFace model to do sentence completion, its intended purpose, in the sample SageMaker notebook.

@3coins 3coins added the maintenance Change related to maintenance of the repository label Jun 21, 2023
3coins
3coins reviewed Jun 21, 2023
View reviewed changes
examples/sagemaker.ipynb Outdated Show resolved Hide resolved
@JasonWeill
Copy link
Collaborator Author

Revised to avoid mention of AWS in prompt

@3coins
Update sagemaker.ipynb
a9daf72 
Update the example for flan-xl.
@3coins
Copy link
Collaborator

3coins commented Jun 21, 2023

@JasonWeill
That sample did not produce a meaningful output. I updated the prompt to provide a legible output.

JasonWeill
JasonWeill commented Jun 21, 2023
View reviewed changes
Copy link
Collaborator Author

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (I can't approve this, since I own the PR)

@JasonWeill JasonWeill merged commit f32c699 into jupyterlab:main Jun 21, 2023
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@JasonWeill @3coins
Change sagemaker example to make more sense (jupyterlab#231)
c3107a5 
* Change sagemaker example to make more sense

* Makes example more neutral

* Update sagemaker.ipynb

Update the example for flan-xl.

---------

Co-authored-by: Piyush Jain <[email protected]>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@JasonWeill @3coins @Marchlak
Change sagemaker example to make more sense (jupyterlab#231)
72e1fba 
* Change sagemaker example to make more sense

* Makes example more neutral

* Update sagemaker.ipynb

Update the example for flan-xl.

---------

Co-authored-by: Piyush Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3coins 3coins 3coins left review comments

Assignees
No one assigned
Labels
@jupyter-ai/core maintenance Change related to maintenance of the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonWeill @3coins