fix default pvc mounting with kubespawner 7 #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unneeded default for pvcNameTemplate
- use new `{pvc_name}` template field to mount the spawner's resolved pvc,
rather than overriding the claim name, which may not match the created pvc
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 3, 2024
jupyterhub/zero-to-jupyterhub-k8s#3537 Merge pull request #3537 from minrk/fix-pvc-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{pvc_name}template field to mount the spawner's resolved pvc, rather than overriding the claim name, which may not match the created pvcI'd really like to be able to have a test for this, but I'm not sure how to set it up here. This is really an issue for this chart, not kubespawner itself.
I believe this closes #3536