Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on GitHub team authentication #2349

Merged

Conversation

j0nnyr0berts
Copy link
Contributor

@welcome
Copy link

welcome bot commented Aug 10, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (preview at https://zero-to-jupyterhub--2349.org.readthedocs.build/en/2349/administrator/authentication.html).

FYI there was a long complicated discussion in the past on GitHub scopes: #687

@consideRatio consideRatio force-pushed the update_github_oauth_documentation branch from e953e3e to 692fdc1 Compare August 10, 2021 12:07
@consideRatio consideRatio merged commit cbc4ce7 into jupyterhub:main Aug 10, 2021
@welcome
Copy link

welcome bot commented Aug 10, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@consideRatio
Copy link
Member

Thank you @j0nnyr0berts!

@j0nnyr0berts j0nnyr0berts deleted the update_github_oauth_documentation branch August 10, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants