Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-kubernetes to 9.0.* #1454

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

clkao
Copy link
Contributor

@clkao clkao commented Oct 22, 2019

It seems the V1PodSpec in 8.0 does not support enableServiceLinks in case we want to disable it.

@consideRatio
Copy link
Member

consideRatio commented Oct 22, 2019

Thanks for the PR! This LGTM.

According to the python-kubernetes compatebility matrix, version 8 match with k8s 1.12's k8s API, 9 with 1.13, and 10 with 1.14. Do we perhaps want to bump it to version 10? What is your take on that @clkao ?

https://github.com/kubernetes-client/python#compatibility


It seems like bumping to version 11 may require some work btw: kubernetes-client/python#974

@manics
Copy link
Member

manics commented Oct 22, 2019

K8s 1.16 is out which means the oldest supported version is 1.14 which justifies moving to 10. On the other hand there are always deployments which lag behind so this would force a K8S upgrade.

Are there any other benefits of moving to 10?

@consideRatio
Copy link
Member

On the other hand there are always deployments which lag behind so this would force a K8S upgrade.

Hmmm, i think the usage of certain python-kubernetes is equivalent to the usage of certain kubectl versions. As you can see from my own kubectl, I work with a very new version but with an older cluster, and that is fine, so I think it does not force any upgrades.

Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-17T17:16:09Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.7-gke.24", GitCommit:"2ce02ef1754a457ba464ab87dba9090d90cf0468", GitTreeState:"clean", BuildDate:"2019-08-12T22:05:28Z", GoVersion:"go1.11.5b4", Compiler:"gc", Platform:"linux/amd64"}

@betatim
Copy link
Member

betatim commented Oct 24, 2019

The GKE cluster for mybinder.org is still on 1.13 but could be upgraded to 1.14. It seems like that is the newest version you can go to (for the k8s master). I'd vote for only increasing the minimum required version of something if we need to in order to fix a bug or get a feature that is needed vs updating because we can as that causes work for people with no benefit (which tends to make people unhappy ;) )

@consideRatio consideRatio merged commit 0a0acb0 into jupyterhub:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants