add triplets for r versions 4.3, 4.4 #1403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise r-4.3 won't work
R.deb download step requires a full x.y.z version, it will 404 on `r-4.4`
manics
reviewed
Feb 2, 2025
| @@ -97,6 +99,9 @@ def r_version(self): | |||
| # available. Users can however explicitly specify the full version to get something specific | |||
| if r_version in version_map: | |||
| r_version = version_map[r_version] | |||
| elif len(r_version.split(".")) == 1: | |||
There was a problem hiding this comment.
Suggested change
| elif len(r_version.split(".")) == 1: | |
| elif len(r_version.split(".")) == 2: |
Shouldn't this be 2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise r-4.3 won't work
perhaps we should error when a minor version isn't found in the dict (or use
x.y.0), because installing R will fail with a 404 trying to download .deb if it's not a 3-part version.