Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JupyterLab version #194

Closed
blink1073 opened this issue Jan 11, 2018 · 6 comments
Closed

Update JupyterLab version #194

blink1073 opened this issue Jan 11, 2018 · 6 comments

Comments

@blink1073
Copy link
Contributor

blink1073 commented Jan 11, 2018

I attempted to follow #169, but the freeze.py script requires docker to be installed locally. I think the workflow that makes most sense is for the JupyterLab release manager to post an issue here requesting an update. The current version should be jupyterlab==0.31.*.

@blink1073
Copy link
Contributor Author

cc @ellisonbg

@ellisonbg
Copy link
Contributor

I think that sounds good - but the maintainers here would have to be ok with that ;-)

@yuvipanda
Copy link
Collaborator

yuvipanda commented Jan 16, 2018 via email

@yuvipanda
Copy link
Collaborator

@betatim did this a few days ago in #225

We've also documented this process in https://github.com/jupyter/repo2docker/blob/master/CONTRIBUTING.md#updating-libraries-installed-for-all-repos.

@blink1073 is local requirement of docker the biggest blocker to having the JupyterLab maintainers do this?

@blink1073
Copy link
Contributor Author

Yes, I didn't mind doing it locally but it felt like an overburden on the jlab maintainer.

@choldgraf
Copy link
Member

I think we should close this since the original issue is taken care of, and if folks want to discuss whether to not require Docker to bump versions of these things, we should discuss in a new issue.

If anybody wants to keep this open, feel free to re-open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants