403 on failed auth for EventStream #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids redirects that won't work for EventStream requests
minrk
commented
Mar 29, 2024
| # raise on failed auth, not redirect | ||
| # can't redirect EventStream to login | ||
| # same as Jupyter's APIHandler | ||
| raise web.HTTPError(403) |
There was a problem hiding this comment.
An alternative would be for the EventStream to inherit from APIHandler instead of the base JupyterHandler, which already has this logic.
consideRatio
approved these changes
Mar 29, 2024
|
Sure! I don't think it's a super important distinction, but either interpretation is valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
302 redirects should only be on for-humans pages, since the EventStream request can't follow the login process.