Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Python 3.12, jupyter_server 1, notebook 5 and 7, and git 2.43 (ubuntu 24.04) #345

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add test for Python 3.12, jupyter_server 1, notebook 5 and 7, and git 2.43 (ubuntu 24.04) #345

merged 2 commits into from
Mar 28, 2024

Conversation

consideRatio
Copy link
Member

No description provided.

yuvipanda
yuvipanda reviewed Mar 28, 2024
View reviewed changes
pyproject.toml
[tool.pytest.ini_options]
addopts = "--verbose --color=yes --durations=10 --cov nbgitpuller"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, as then everyone can just run pytest locally.

@yuvipanda
Copy link
Contributor

Not sure why the test is failing though. LGTM once that is fixed

@consideRatio consideRatio changed the title Add test for Python 3.12 and git 2.43 (ubuntu 24.04) Test for Python 3.12, jupyter_server 1, notebook 7, and git 2.43 (ubuntu 24.04) Mar 28, 2024
@consideRatio consideRatio changed the title Test for Python 3.12, jupyter_server 1, notebook 7, and git 2.43 (ubuntu 24.04) Add test for Python 3.12, jupyter_server 1, notebook 7, and git 2.43 (ubuntu 24.04) Mar 28, 2024
@consideRatio
Copy link
Member Author

Notebook 6 required a pyzmq version that didn't support py312. I fixed it by not forcing notebook 6 to be installed in the Python 3.12 test, but instead pinning notebook 6 in other tests.

@consideRatio consideRatio changed the title Add test for Python 3.12, jupyter_server 1, notebook 7, and git 2.43 (ubuntu 24.04) Add test for Python 3.12, jupyter_server 1, notebook 5 and 7, and git 2.43 (ubuntu 24.04) Mar 28, 2024
@consideRatio consideRatio requested a review from minrk March 28, 2024 21:46
@consideRatio consideRatio mentioned this pull request Mar 28, 2024
Merged
@consideRatio consideRatio merged commit 518c9c8 into jupyterhub:main Mar 28, 2024
9 checks passed
@consideRatio
Copy link
Member Author

Thanks @yuvipanda and @minrk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda left review comments

@minrk minrk minrk approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@consideRatio @yuvipanda @minrk