-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate docs to RTD #297
migrate docs to RTD #297
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Ya that domain is with me, happy to repoint it. As long as existing links to the generator don't break, all <3 |
New link is up at https://nbgitpuller.readthedocs.io/en/latest/link.html, if you want to update nbgitpuller.link. working on setting up redirects, and noticed weird behavior that the current nbgitpuller.link is pointing to |
#298 adds all the redirects, including the gh-pages special case |
@minrk nbgitpuller.link redirect updated! |
link generator on RTD doesn't quite work. I believe due to a theme update, some CSS selector assumptions aren't held. |
updates HTML a bit, only loads main on the link page
this now fixes the link generator as well to be compatible with the updated bootstrap in the sphinx theme |
rather than using absolute URLs for an internal page
There might be some time pressure to merge this, since now all the links are pointing to the not working link generator page, which is fixed by this PR. |
full-width overflows by the width of the sidebar on the opposite side
For me, the link generator is still not working. |
Are you unable to access https://nbgitpuller.readthedocs.io/en/latest/link.html @frankier, or do you mean that the link generator generated links when having third party cookies disabled isn't working against mybinder.org? |
@frankier when generating a nbgitpuller link for use with mybinder.org that first builds a docker image before it sends a launch request to a jupyterhub, you need to enter two separate URLs. One for the git repository that is used to build a github image, and one for the content to be pulled with nbgitpuller. Otherwise, a normal mybinder.org link would suffice I think. There is certainly a UI bug of having a green checkbox on "Git content repository URL" even though its not filled in and is required to be filled in to work. |
Whoops! I was so used to it not working, I suppose I just read that as still broken. Sorry for the noise. |
closes #128
I ended up here from: