Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binder folder with link_generator.ipynb #249

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jan 20, 2022

Before we had a link generator as a nice website, we had a notebook that could be run from mybinder.org. This is no longer a referenced option in our documentation or similar, so my suggestion is that we remove the link generator and the entire binder folder.

nbgitpuller-old-binder-link-generator

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@consideRatio
Copy link
Member Author

Thanks for the review @GeorgianaElena! I figure I'll ping @choldgraf for having created the notebook in the first place. Okay to delete it?

@choldgraf
Copy link
Member

Go for it!

@consideRatio consideRatio merged commit 442b6cd into jupyterhub:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants