Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: ensure tox run's flake8 as well #148

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jul 28, 2020

Apparently the tox-travis package did something, but it caused a
discrepancy between the local development experience and didn't run both
environments. So I'm removing it in favor of something simpler that
doesn't require additional understanding about tox-travis.

Apparently the tox-travis package did something, but it caused a
discrepancy between the local development experience and didn't run both
environments. So I'm removing it in favor of something simpler that
doesn't require additional understanding about tox-travis.
@consideRatio
Copy link
Member Author

Wieee now flake8 runs again as I assumed it did before as well.

@consideRatio consideRatio merged commit b0670c2 into jupyterhub:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant