tab activation on link generator #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
nbgitpuller_rest
branch
from
b77c35f to
ddb1d04
Compare
choldgraf
force-pushed
the
nbgitpuller_rest
branch
from
ddb1d04 to
069687b
Compare
|
LGTM :) |
|
ok then I'm gonna self-merge since this is a docs PR :-) |
|
@choldgraf I recall working to fix an issue with query params not being passed ~a year ago, and think the URL query parameters do pass forward correctly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively minor follow-up on @GeorgianaElena 's PR adding Binder functionality. It does:
closes #131
See this link for a demo:
https://110-92329878-gh.circle-artifacts.com/0/html/link.html?tab=binder&repo=wowmyrepo&branch=itsabranch
@yuvipanda do you know if REST params are passed-through with a redirect? ie, will
nbgitpuller.link?tab=binderwork?