Use shallow clones by default #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deep clones take up so much unnecessary space, and are unused 99% of the time. Shallow cloning in git is pretty good these days. This doesn't touch pre-existing clones
ryanlovett
approved these changes
Feb 7, 2020
|
I think this makes sense for nbgitpuller to do: LGTM. |
consideRatio
reviewed
Feb 7, 2020
consideRatio
force-pushed
the
default/shallow
branch
from
b2d3cec to
177a468
Compare
|
I fixed all the issues in the current PRs tests, but additional tests were added since this PR was created that is failing as well. I'll see if I can fix those in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep clones take up so much unnecessary space, and are unused
99% of the time. Shallow cloning in git is pretty good these
days. This doesn't touch pre-existing clones