cd, cert-manager: use --repo during upgrade instead of helm repo add/update #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
commented
May 27, 2022
Comment on lines
+258
to
261
| "--namespace=cert-manager", | ||
| "--repo=https://charts.jetstack.io", | ||
| "cert-manager", | ||
| "cert-manager", |
There was a problem hiding this comment.
The first "cert-manager" is the release name (helm chart installation name), and the second "cert-manager" is the chart name to be found in the helm chart repo.
sgibson91
approved these changes
May 27, 2022
consideRatio
added
the
test-staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use
helm repo addandhelm repo updateis a more involved practice than just getting the helm chart repository when needed by using the--repoflag inhelm install|upgradecommands.I'm working towards resolving #2183 but tries to update misc parts along the way.