[Feature Request] Allow looking up the userdn rather than having to specify a template #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without bind_dn_template, any password is authenticated successfully! (after update from 1.1 to 1.2.2)
#44
If don't set
bind_dn_template
-bind_dn_template=[]
and
isBound
don't set Truehttps://github.com/jupyterhub/ldapauthenticator/blob/master/ldapauthenticator/ldapauthenticator.py#L315-L335
But we can take
userdn
from connection after search userconn.response[0]['dn']
this is my temporarily dirty fix
If you ok about the idea, I try to make pull-request correctly and beautifully