Add Travis CI setup and simple tests #134
Conversation
marcusianlevine
force-pushed
the
master
branch
5 times, most recently
from
137578c to
0206e4f
Compare
marcusianlevine
force-pushed
the
master
branch
2 times, most recently
from
1b26fcd to
2e76d58
Compare
|
This looks good to me! One nitpick: in other repos we started running the lint tests before the other tests because they tend to be fast. If they run first it'll tell a PR author that something needs fixing quickly instead of waiting a long time for all the other tests to run. This isn't (yet) an issue here as the tests are fast. What do you think about moving them up? Thought for contributing guide: should we copy&paste some of the instructions from the jupyterhub repo around setting up black and the pre-commit hooks? I'll merge now as this PR as-is is an improvement on what we currently have. We can make a new PR for the two points above |
|
Thanks for the quick response Tim! Regarding the build order, I included the Since Travis runs all build steps in parallel, I don't think reordering is necessary when using Regarding the contributing guide, I'll open another PR with a variant of the official guide, including some extra steps I used to develop locally with Docker |
|
TIL about The re-ordering and slow builds thing was on my mind because in https://github.com/jupyter/repo2docker we have all the builds that use all the time and it is a bit of a pain :-/ |
In an effort to make this repo more maintainable, I ported the Travis setup from the main jupyterhub/jupyterhub repo