Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 6.1.0 #768

Merged

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Aug 22, 2023

I propose that we cut a release now with bugfixes, a performance improvement, and the unlisted_choice functionality part of profile_lists -> profile_options.

If approved by monday next week, I'll cut a release then.

@GeorgianaElena
Copy link
Member

@consideRatio, I think we might want to also fix this #758 as part of a new release. A workaround we've used for this was https://github.com/2i2c-org/infrastructure/pull/2865/files.

@consideRatio
Copy link
Member Author

Ah, I agree!

@consideRatio consideRatio marked this pull request as draft August 22, 2023 10:10
@consideRatio consideRatio force-pushed the pr/add-changelog-for-6.1.0 branch from df01d45 to b234162 Compare September 1, 2023 14:59
@consideRatio consideRatio marked this pull request as ready for review September 1, 2023 15:00
Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved the merge conflicts, and want to appreciate you doing all the release prep work, @consideRatio! I'm happy to share some of the load if you so choose. But this is ready to go now from my perspective.

@consideRatio
Copy link
Member Author

I've not pushed on this as i felt we absolutely need a note in the changelog to help users remediate the consequences of the bug as well - this is the place to make such note.

I plan to test a script by Min tomorrow helping with that, possibly make a smaller tweak, and then link to it from the changelog.

@shaneknapp
Copy link
Contributor

@consideRatio thanks for the update!

@consideRatio consideRatio force-pushed the pr/add-changelog-for-6.1.0 branch from e552ac2 to 5b8ae81 Compare September 28, 2023 16:10
Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@consideRatio consideRatio merged commit 7cde1be into jupyterhub:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release planning for 6.1.0
4 participants