Add changelog for KubeSpawner 2.0.0 #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
requested review from
GeorgianaElena,
manics,
minrk,
sgibson91 and
yuvipanda
yuvipanda
reviewed
Nov 19, 2021
yuvipanda
approved these changes
Nov 19, 2021
yuvipanda
approved these changes
Nov 19, 2021
manics
reviewed
Nov 19, 2021
Co-authored-by: Simon Li <[email protected]>
I'm just nudging us towards a KubeSpawner 2.0.0 release, which i consider a blocker for Z2JH 2.0.0, which is also blocked by JupyterHub 2.0.0. Do you know of things you want to introduce as breaking changes in KubeSpawner 2.0.0? |
manics
reviewed
Nov 22, 2021
Co-authored-by: Simon Li <[email protected]>
minrk
approved these changes
Nov 23, 2021
consideRatio
commented
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I requested a lot of people to review this change, as its relevant that both we are in agreement of making a major version release, and that the communication about this breaking change is clear within the changelog.
This would be a release that would go with the Z2JH 2.0.0 release, and that the breaking change in #545 would align well with all other containers we run as part of the Helm chart - we default to a secure configuration and ask users to escalate explicitly rather than the other way.