Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: schedule test runs twice a week #452

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Feb 20, 2024

We had test failures in main branch (#449), and realizing that something has started failing is often something that goes with tracking what dependencies has changed.

If I think there is a test that has started failing for some reason outside a code change in repo, I do the following:

  1. Look at workflows run recently to identify when they last worked and when they started failing
  2. Compare pip freeze output between succeeding tests and failing tests by copy pasting into ok.txt and fail.txt and doing git diff --no-index -U0 -- ok.txt fail.txt (-U0 means 0 lines of context surrounding changes observed)

This is troublesome if there isn't a workflow run recently though, but having regular runs, for example twice a week, would do the trick.

@consideRatio
Copy link
Member Author

In #449 (comment) @manics wrote:

I think this could be a good case for using dependabot to pin some dependencies for CI testing. Keep the dev dependencies unrestricted in pyproject.toml, but use a separate dev-ci-requirements.txt file for CI only and let dependabot tell us when there's a UI change in lab or notebook.

@manics I prefer settling for doing this (ensure more regular runs of tests) over adding dependabot to work on a CI specific dependency file as it avoids some complexity and maintenance chore. What do you think?

@consideRatio consideRatio merged commit 0b6669f into jupyterhub:main Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant