Fix double formatting of callables (command, environment, request_headers_override)
#437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the environment has an escaped variable (so, a string), the server should start without failing to format it.
It was doing double formatting, which broke when passing environment variables with escaped strings (i.e {{var}}).
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
etejedor
added a commit
to etejedor/jupyter-images
that referenced
this pull request
Dec 8, 2023
To prevent double formatting of environment variables. See PR upstream: jupyterhub/jupyter-server-proxy#437
etejedor
added a commit
to etejedor/jupyter-images
that referenced
this pull request
Dec 8, 2023
To prevent double formatting of environment variables. See PR upstream: jupyterhub/jupyter-server-proxy#437
etejedor
added a commit
to swan-cern/jupyter-images
that referenced
this pull request
Dec 8, 2023
To prevent double formatting of environment variables. See PR upstream: jupyterhub/jupyter-server-proxy#437
consideRatio
changed the title
command, environment, request_headers_override)
|
I saw that this was a bug for Thank you @diocas for the thorough work fixing this with a description and a test!! ❤️ 🎉 🌻 |
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a server has a callable as the environment, jupyter-server-proxy formatted it twice.
If that callable returned an escaped var (i.e.
{ "MYVAR": "{{var}}" }), the server was crashing when doing the second formatting (as "var" does not exist).With this PR I only format once, wether it's callable or dict.